fix: Clean up streaming tasks when last WebSocket client disconnects #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clients force quit or disconnect ungracefully, streaming tasks were continuing to run and try to broadcast to disconnected sockets. Over time, this caused resource exhaustion (memory, file descriptors) that made the server appear unreachable. This fix ensures that when the last WebSocket client disconnects, all streaming tasks are properly cancelled and removed from the task registry. Addresses the issue where server became unreachable after clients were force quit, showing "No route to host" and DNS resolution errors.
X9X0
deleted the
claude/fix-lablink-login-crash-01PLQrYHbpfS6sWQF4WzX4ss
branch
X9X0
added a commit
that referenced
this pull request
Dec 7, 2025
…ecture ## Summary Unified version management across all components (server, client, launcher, Docker) using a single VERSION file as the source of truth. Updated to v1.2.0 to accurately reflect work completed since v1.0.0 (30+ PRs merged). ## Version System Changes ### Unified to v1.2.0 - Analyzed git history from v1.0.0 through current main - Determined v1.2.0 accurately represents features and fixes delivered - All components now read from single VERSION file ### Components Updated - VERSION file: 0.28.0 → 1.2.0 - README badge: 1.0.1 → 1.2.0 - Server: Now reads VERSION (already implemented) - Client: Added dynamic VERSION reading at startup - Launcher: Added __version__ variable from VERSION - Docker images: Labels updated to 1.2.0 - Copyright: Updated to © 2025 (project start year) ## CHANGELOG Updates Added comprehensive release notes for missing versions: ### v1.2.0 (2025-12-06) - Server update system with stable/development modes (#114, #118, #119) - Smart branch filtering and UI consolidation (#120) - Enhanced dropdown visibility - Multiple bug fixes (#105, #106, #108, #121) ### v1.0.1 (2025-11-28) - Equipment control panel (#104) - GUI system launcher with diagnostics (#70-74) - Raspberry Pi image builder (#75-76) - Waveform analysis tools (#79) - Automated test sequence builder (#80) - Remote firmware update (#81) - Equipment diagnostics system (#84-87) - WebSocket integration completion (#77) ## Automation & Documentation ### Created scripts/bump_version.py Automated version bumping tool with: - Support for major/minor/patch increments - Automatic VERSION file updates - CHANGELOG.md section generation - Git commit and tag creation - Dry-run mode for testing Usage: python scripts/bump_version.py patch # 1.2.0 → 1.2.1 python scripts/bump_version.py minor # 1.2.0 → 1.3.0 python scripts/bump_version.py major # 1.2.0 → 2.0.0 ### Created docs/VERSIONING.md Complete versioning system documentation covering: - Single-source architecture - Semantic versioning guidelines - Automated bumping procedures - Manual update processes - Troubleshooting guide - Best practices ## Files Modified Core Version Files: - VERSION (0.28.0 → 1.2.0) - CHANGELOG.md (added v1.0.1 and v1.2.0 entries) - README.md (badge updated to 1.2.0) Component Updates: - client/main.py (dynamic VERSION reading) - lablink.py (added __version__ from VERSION) - docker/Dockerfile.server (label 1.2.0) - docker/Dockerfile.web (label 1.2.0) Copyright Updates (© 2025): - docs/USER_GUIDE.md - client/ui/main_window.py New Files: + scripts/bump_version.py (version management tool) + docs/VERSIONING.md (complete documentation) ## Benefits ✅ Single source of truth for version (VERSION file) ✅ Consistent versioning across all components ✅ Accurate version history in CHANGELOG ✅ Automated version bumping workflow ✅ Complete documentation for future updates ✅ Git-tagged releases (v1.2.0) ## Testing Verified: - VERSION file: 1.2.0 ✓ - Server reads VERSION correctly ✓ - Client would read VERSION at startup ✓ - Launcher reads VERSION correctly ✓ - bump_version.py dry-run works ✓ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clients force quit or disconnect ungracefully, streaming tasks were continuing to run and try to broadcast to disconnected sockets. Over time, this caused resource exhaustion (memory, file descriptors) that made the server appear unreachable.
This fix ensures that when the last WebSocket client disconnects, all streaming tasks are properly cancelled and removed from the task registry.
Addresses the issue where server became unreachable after clients were force quit, showing "No route to host" and DNS resolution errors.