Skip to content

Conversation

@lognaturel
Copy link
Contributor

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@lognaturel lognaturel requested a review from yanokwa December 8, 2020 21:16
yanokwa
yanokwa previously approved these changes Dec 8, 2020
Copy link
Contributor

@yanokwa yanokwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had missed the change in setup.py, but I made the change and force pushed. It's documented at https://github.com/XLSForm/pyxform#releasing-pyxform, but guess you missed it? I generally grep for "previous.version.number" as a habit.

@yanokwa yanokwa merged commit 87325c5 into XLSForm:master Dec 8, 2020
@lognaturel lognaturel deleted the prep-v1.3.0 branch December 9, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants