Skip to content

Conversation

@zipus
Copy link
Contributor

@zipus zipus commented Dec 2, 2025

Closes #281

@kislyuk
Copy link
Member

kislyuk commented Dec 2, 2025

Thanks, this looks great!

FYI: SHA1 is deprecated for digital signatures due to cryptographic weaknesses. I'm totally on board with this change, but I will eventually make this code use a different digest algorithm by default; using SHA1 will require passing a custom setting. I will let you know here when I get around to that. For now, this is good.

@kislyuk
Copy link
Member

kislyuk commented Dec 2, 2025

Hmm it looks like there are some CI failures, I'll have to take a look.

@zipus
Copy link
Contributor Author

zipus commented Dec 2, 2025

Hmm it looks like there are some CI failures, I'll have to take a look.

Ok, let me know if u need anything from my side.

@zipus
Copy link
Contributor Author

zipus commented Dec 2, 2025

Hmm it looks like there are some CI failures, I'll have to take a look.

While developing on my end other modules depending on signxml I found tests failing due to some certs not having COUNTRY_NAME, ORGANIZATION_NAME, ORGANIZATIONAL_UNIT_NAME, COMMON_NAME. Might be that?

@kislyuk
Copy link
Member

kislyuk commented Dec 4, 2025

The changes look correct, I'll adjust the tests in master. Merging

@kislyuk kislyuk merged commit 42bc7bf into XML-Security:main Dec 4, 2025
1 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XAdES EPES: facturae/CAOC requires legacy SigningCertificate with specific X509IssuerName format

2 participants