refactor: simplify SubmitLink selection by querying all anchors and finding by text#876
Merged
refactor: simplify SubmitLink selection by querying all anchors and finding by text#876
Conversation
…inding by text 一下子解决所有问题...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Simplify and stabilize how we select the Submit link on the problem page.
Previously we relied on a brittle chain of
nth-child()selectors with multiple null checks, which repeatedly broke whenever the DOM structure changed (see #869, #861).This PR queries all anchors within the container and selects the one whose text is
'提交', making the code resilient to DOM reordering and easier to maintain.How does this PR accomplish the above?:
Replace multiple positional selectors and
if (SubmitLink == null)fallbacks with a single, readable selection:Benefits:
nth-child()dependenciesNo UI/behavior changes expected; logic is functionally equivalent with a more robust selector.
By submitting this pull request, I confirm the following:
git rebase)