fix for modules\system\language\english\admin\modulesadmin.php

[mambax7]

Summary by CodeRabbit

• Chores
  • Reorganized language strings for user access rights notifications to improve naming consistency and clarity. Success and error messages are now separated under distinct labels for better maintainability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1da75f and df8e53c.

📒 Files selected for processing (1)

• htdocs/modules/system/language/english/admin/modulesadmin.php

---

Walkthrough

Renamed language constants in the English admin module language file to clarify success and error message associations. The success message constant was renamed from _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR to _AM_SYSTEM_MODULES_ACCESS_USER_ADD, and the error constant was renamed from _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR_ERROR to _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR.

Changes

Cohort / File(s)	Summary
Language Constant Refactoring htdocs/modules/system/language/english/admin/modulesadmin.php	Renamed success constant from _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR to _AM_SYSTEM_MODULES_ACCESS_USER_ADD; renamed error constant from _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR_ERROR to _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR to eliminate redundancy and follow naming conventions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[Copilot]

Pull request overview

This PR fixes a naming inconsistency in language constant definitions for the system module's modulesadmin interface. The constants _AM_SYSTEM_MODULES_ACCESS_USER_ADD and _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR had incorrect names where the first was mistakenly named with an _ERROR suffix despite being a success message, and the second had a duplicated _ERROR_ERROR suffix.

Changes:

• Corrected constant name from _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR to _AM_SYSTEM_MODULES_ACCESS_USER_ADD (success message)
• Corrected constant name from _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR_ERROR to _AM_SYSTEM_MODULES_ACCESS_USER_ADD_ERROR (error message)