Skip to content

Superglobal Migration to Xmf\Request#1633

Merged
mambax7 merged 35 commits into
XOOPS:masterfrom
mambax7:feature/superglobal-to-XmfRequest_migration
Mar 8, 2026
Merged

Superglobal Migration to Xmf\Request#1633
mambax7 merged 35 commits into
XOOPS:masterfrom
mambax7:feature/superglobal-to-XmfRequest_migration

Conversation

@mambax7
Copy link
Copy Markdown
Collaborator

@mambax7 mambax7 commented Mar 7, 2026

  • htdocs root: ajaxfineupload.php, image.php
  • include/: common.php, notification_update.php, + all comment/findusers/site-closed files
  • modules/profile/: search.php, edituser.php, activate.php, register.php, changemail.php, changepass.php, + all admin files
  • modules/system/: admin/tplsets/, admin/comments/, admin/groups/, admin/users/, themes (transition, default, dark)
  • modules/pm/: readpmsg.php, viewpmsg.php, admin/prune.php, pmlite.php
  • class/: xoopseditor/sampleform.inc.php, all TinyMCE plugins (tinymce/tinymce5/tinymce7)
  • install/: All 9 page files + installwizard.php
  • xoops_lib/modules/protector/: admin/center.php, admin/prefix_manager.php, admin.php, module_icon.php, postcommon_register_insert_js_check.php, index.php, notification_update.php
  • Frameworks/: art/functions.ini.php

Summary by CodeRabbit

  • Refactor

    • Centralized request handling across the application using a unified request API for GET/POST/COOKIE inputs.
  • Bug Fixes / Security

    • Improved input validation and sanitization, removed error-suppression patterns, and tightened token/file handling and URL validation.
  • Tests

    • Added comprehensive regression tests covering request parsing, sanitization, and GET/POST/COOKIE separation.
  • UX

    • Profile-field "required" toggle converted to a POST-backed action with CSRF protection.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants