Feature/php doc2 #663
Closed
Feature/php doc2 #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2019
Merged
geekwright
reviewed
Mar 27, 2019
Contributor
geekwright
left a comment
geekwright
left a comment
There was a problem hiding this comment.
Will close this for fixes in #664
| * @static | ||
| * | ||
| * @param $uname used to lookup in LDAP bypass config | ||
| * @param used $uname to lookup in LDAP bypass config |
| * Tries to find and include a file for a cache engine and returns object instance | ||
| * | ||
| * @param $name Name of the engine | ||
| * @param Name $name of the engine |
| $sql = 'SELECT COUNT(*) as `count` FROM ' . $prefixedTable . ' '; | ||
| if (isset($criteria) && is_subclass_of($criteria, '\CriteriaElement')) { | ||
| /* @var $criteria \CriteriaCompo */ | ||
| /* @var \CriteriaCompo $criteria */ |
Contributor
There was a problem hiding this comment.
No direct changes are to be made in the libraries directory. The build will overwrite these changes, making this pointless.
| * Retrieves config info based on the key. | ||
| * | ||
| * @param $file_name string config key (filename/section/var) | ||
| * @param string $file_name config key (filename/section/var) |
Contributor
There was a problem hiding this comment.
This directory should be a perfect copy of the upstream Smarty. No changes without very compelling and documented reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.