Skip to content

chore(coderabbit): align test review instruction with PHPUnit ^11.2#104

Merged
mambax7 merged 1 commit into
XOOPS:masterfrom
mambax7:chore/coderabbit-phpunit-version
Jun 13, 2026
Merged

chore(coderabbit): align test review instruction with PHPUnit ^11.2#104
mambax7 merged 1 commit into
XOOPS:masterfrom
mambax7:chore/coderabbit-phpunit-version

Conversation

@mambax7

@mambax7 mambax7 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

What

Update the tests/**/*.php path_instruction in .coderabbit.yaml from
"Tests must work across PHPUnit 9.6, 10, and 11" to point at PHPUnit ^11.2
(the project's pinned version) and explicitly tell CodeRabbit not to flag the
attribute API.

Why

The old instruction made CodeRabbit repeatedly flag the project's PHPUnit
attribute API#[Test], #[DataProvider], #[CoversClass] — and the
absence of a test* method-name prefix as "PHPUnit 9.6 incompatibilities".
This is a false positive: the project pins PHPUnit ^11.2 (composer /
CLAUDE.md) and uses those attributes throughout (CriteriaTest,
XoopsSecurityTest, the upgrade suite, etc.). The bogus finding has appeared on
three separate PRs, where it had to be dismissed each time.

Aligning the instruction with the real test baseline stops the recurring noise
without weakening any actual test-quality review.

Summary by Sourcery

CI:

  • Adjust CodeRabbit test-review instructions to reflect PHPUnit ^11.2 and prevent false positives related to attribute-based tests and method naming.

The tests path_instruction said "Tests must work across PHPUnit 9.6, 10, and 11",
which made CodeRabbit repeatedly flag the project's #[Test]/#[DataProvider] attributes
(and the lack of a test* method prefix) as PHPUnit 9.6 incompatibilities — a false
positive on three separate PRs. The project pins PHPUnit ^11.2 and uses the attribute
API throughout. Point the instruction at ^11.2 and tell CodeRabbit not to flag the
attribute API.
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 20ff8a6b-a332-443a-8943-ddf287daa895

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sourcery-ai

sourcery-ai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CodeRabbit review configuration for test files to reflect the project’s pinned PHPUnit ^11.2 version and to prevent false-positive warnings about PHPUnit’s attribute-based test API and non-prefixed test method names.

File-Level Changes

Change Details Files
Align CodeRabbit test-review instructions with PHPUnit ^11.2 and clarify acceptable PHPUnit attribute usage.
  • Update the PHPUnit compatibility note in the test review instructions to match the project’s pinned PHPUnit ^11.2 baseline.
  • Explicitly document that PHPUnit attribute-based annotations (#[Test], #[DataProvider], #[CoversClass]) are expected and should not be flagged.
  • Clarify that the absence of a test* method-name prefix must not be treated as a PHPUnit 9.6/10 incompatibility in automated review feedback.
.coderabbit.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .coderabbit.yaml configuration file to specify that the project pins PHPUnit ^11.2 and uses its attribute API (such as #[Test], #[DataProvider], and #[CoversClass]). It instructs the review tool not to flag these attributes or the absence of a test* method-name prefix as PHPUnit 9.6/10 incompatibilities. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.52%. Comparing base (62d52ff) to head (1bcc0fa).
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
+ Coverage     18.13%   18.52%   +0.38%     
- Complexity     7854     7997     +143     
============================================
  Files           666      670       +4     
  Lines         43208    43703     +495     
============================================
+ Hits           7837     8096     +259     
- Misses        35371    35607     +236     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mambax7 mambax7 merged commit 39eddfb into XOOPS:master Jun 13, 2026
13 checks passed
@mambax7 mambax7 deleted the chore/coderabbit-phpunit-version branch June 13, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant