TinyMCE default config was not actually loading the full plugin set.#24
TinyMCE default config was not actually loading the full plugin set.#24mambax7 merged 2 commits intoXOOPS:masterfrom
Conversation
- uses a comma-separated plugins list, which is what the XOOPS TinyMCE 7 loader expects - restores xoopsimagemanager to the loaded plugins and toolbar - enables the menubar again - replaces legacy styleselect with TinyMCE 7’s styles control - removes insertfile, which is not needed here
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 49 minutes and 52 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated TinyMCE 7 editor configuration in a single settings file. Changed plugin format from space-separated to comma-separated strings, added xoopsimagemanager to plugins, replaced styleselect with styles in toolbar, removed insertfile, and enabled the menubar option. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
============================================
- Coverage 19.23% 18.00% -1.23%
- Complexity 7584 7803 +219
============================================
Files 621 665 +44
Lines 40085 42806 +2721
============================================
Hits 7709 7709
- Misses 32376 35097 +2721 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the TinyMCE 7 default configuration so the XOOPS loader parses and loads the intended full plugin set, restoring missing UI capabilities.
Changes:
- Switches the
pluginssetting to a comma-separated list (XOOPS loader expectation) and restoresxoopsimagemanager - Updates toolbar controls for TinyMCE 7 (
styles) and removesinsertfile - Re-enables the menubar
| 'selector' => 'textarea#summary, textarea#body, textarea#message', // keep if targeting multiple fields | ||
| 'plugins' => 'advlist anchor autolink charmap code hr image imagetools lists link media preview searchreplace table xoopsemoticons xoopscode', // removed 'xoopsimagemanager' | ||
| 'toolbar' => 'undo redo | styleselect | bold italic | forecolor backcolor removeformat | alignleft aligncenter alignright alignjustify | bullist numlist outdent indent | table tabledelete | insertfile image media link | hr | xoopsemoticons xoopscode | code', | ||
| 'plugins' => 'advlist,anchor,autolink,charmap,code,hr,image,imagetools,lists,link,media,preview,searchreplace,table,xoopsimagemanager,xoopsemoticons,xoopscode', |
There was a problem hiding this comment.
imagetools is a legacy TinyMCE plugin name that may not exist in TinyMCE 7 (it was replaced by editimage in newer TinyMCE versions). If imagetools is not available, it can trigger plugin load errors and prevent the editor from initializing or from loading subsequent plugins. Consider replacing imagetools with the TinyMCE 7-equivalent plugin (likely editimage) and, if needed, adding the corresponding toolbar button(s).
| 'plugins' => 'advlist,anchor,autolink,charmap,code,hr,image,imagetools,lists,link,media,preview,searchreplace,table,xoopsimagemanager,xoopsemoticons,xoopscode', | |
| 'plugins' => 'advlist,anchor,autolink,charmap,code,hr,image,editimage,lists,link,media,preview,searchreplace,table,xoopsimagemanager,xoopsemoticons,xoopscode', |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@htdocs/class/xoopseditor/tinymce7/settings.php`:
- Line 26: Remove the deprecated imagetools plugin from the TinyMCE plugins list
in settings.php: locate the 'plugins' configuration string (the array entry
containing advlist,anchor,autolink,...,xoopsemoticons,xoopscode) and delete the
substring "imagetools," so the plugins value no longer references imagetools,
preventing failed-to-load warnings in TinyMCE 7.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: ad8b265d-3209-49cf-86fb-2903d0d13bf9
📒 Files selected for processing (1)
htdocs/class/xoopseditor/tinymce7/settings.php
|
Summary by CodeRabbit