Skip to content

fix(ci): changelog workflow — PR-based delivery + Node 24 checkout#67

Merged
mambax7 merged 2 commits into
XOOPS:masterfrom
mambax7:chore/bump-checkout-node24
May 15, 2026
Merged

fix(ci): changelog workflow — PR-based delivery + Node 24 checkout#67
mambax7 merged 2 commits into
XOOPS:masterfrom
mambax7:chore/bump-checkout-node24

Conversation

@mambax7
Copy link
Copy Markdown
Contributor

@mambax7 mambax7 commented May 15, 2026

Summary

Makes the Changelog workflow (added in #66) actually work end-to-end. Three changes to .github/workflows/changelog.yml:

  1. PR-based delivery (the real fix). The first dispatch generated CHANGELOG.md fine but git push origin HEAD:master was rejected by the repository ruleset — "Changes must be made through a pull request." master is protected; a CI bot can't push to it. The workflow now uses peter-evans/create-pull-request to push a fixed automation/update-changelog branch and open/update a PR (no-ops when nothing changed). Added pull-requests: write. No privileged bypass on the protected branch — same PR-only governance as the rest of the repo.
  2. Node 24. actions/checkout bumped v4 → v6.0.2 (Node 20 is deprecated; forced→24 on 2026-06-02).
  3. All three actions remain SHA-pinned with the tag in a trailing comment (supply-chain hardening, consistent with the earlier SonarQube fix on this file): actions/checkout, orhun/git-cliff-action@v4.8.0 (composite/bash, Node-unaffected), peter-evans/create-pull-request@v8.1.1.

Earlier intermediate commits on this branch (the git diff --cached detection tweak) are superseded by the create-pull-request action, which handles change detection itself; the net diff is the final state above. Squash-merge.

Prerequisite (repo setting)

peter-evans/create-pull-request needs Settings → Actions → General → "Allow GitHub Actions to create and approve pull requests" enabled, or the PR-open step will fail with a permissions error. (Confirmed acceptable when choosing this approach.)

Test plan

  • Ensure the "Allow GitHub Actions to create and approve pull requests" setting is ON
  • Merge, then run Actions → Changelog → Run workflow (workflow_dispatch)
  • Confirm: no Node 20 warning; a PR from automation/update-changelog is opened with CHANGELOG.md
  • Merge that PR; re-run the workflow and confirm it no-ops (no duplicate/empty PR) when nothing changed

GitHub flagged the pinned actions/checkout (v4) as a Node.js 20 action;
Node 20 is forced to 24 on 2026-06-02 and removed 2026-09-16. Bump to
v6.0.2, which runs on Node 24, still SHA-pinned for supply-chain safety.

orhun/git-cliff-action is a composite/bash action (no Node runtime), so
it is unaffected and stays at v4.8.0.
Copilot AI review requested due to automatic review settings May 15, 2026 15:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Warning

Rate limit exceeded

@mambax7 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ea4eddd3-f2c7-42a0-84e0-6565d69fa614

📥 Commits

Reviewing files that changed from the base of the PR and between 690aa8a and b01d9c7.

📒 Files selected for processing (1)
  • .github/workflows/changelog.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the SHA-pinned actions/checkout reference in the Changelog workflow from v4 (Node 20) to v6.0.2 (Node 24) to silence the upcoming Node 20 deprecation warning.

Changes:

  • Update actions/checkout SHA pin to de0fac2e4500dabe0009e67214ff5f5447ce83dd (v6.0.2).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.14%. Comparing base (8129f7d) to head (b01d9c7).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     18.13%   18.14%           
  Complexity     7854     7854           
=========================================
  Files           666      666           
  Lines         43208    43208           
=========================================
+ Hits           7837     7838    +1     
+ Misses        35371    35370    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The first workflow_dispatch run succeeded but committed nothing: the
guard used `git diff --quiet -- CHANGELOG.md`, which ignores untracked
files. On the first run CHANGELOG.md is brand-new, so the diff was
empty and the step reported "nothing to commit". Stage first, then
check `git diff --cached --quiet` against HEAD, which detects both new
and modified files. (Unrelated to the Node 20 deprecation warning.)
@mambax7 mambax7 changed the title chore(ci): bump actions/checkout to v6 (Node 24) in changelog workflow fix(ci): changelog workflow — commit generated file + Node 24 checkout May 15, 2026
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@mambax7 mambax7 merged commit 2867eb0 into XOOPS:master May 15, 2026
11 of 12 checks passed
@mambax7 mambax7 changed the title fix(ci): changelog workflow — commit generated file + Node 24 checkout fix(ci): changelog workflow — PR-based delivery + Node 24 checkout May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants