fix: Don't use github.var directly#107
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the create-issue composite action to avoid interpolating github.* context values directly inside the shell script by passing them through step environment variables first.
Changes:
- Adds workflow-related GitHub context values to the append step’s
env. - Replaces direct
${{ github.* }}usage in the generated issue body with shell variable references.
Comments suppressed due to low confidence (1)
create-issue/action.yml:72
- The workflow-run URL uses invalid Bash parameter expansion syntax (
${ ... }with spaces), so this line will triggerbad substitutionand fail the composite action when workflow info is appended.
**Workflow run:** ${ GITHUB_SERVER_URL }/${ GITHUB_REPOSITORY }/actions/runs/${ GITHUB_RUN_ID }
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bthomee
approved these changes
May 14, 2026
Comment on lines
+56
to
+62
| GITHUB_WORKFLOW: ${{ github.workflow }} | ||
| GITHUB_RUN_ID: ${{ github.run_id }} | ||
| GITHUB_SHA: ${{ github.sha }} | ||
| GITHUB_REF: ${{ github.ref }} | ||
| GITHUB_ACTOR: ${{ github.actor }} | ||
| GITHUB_SERVER_URL: ${{ github.server_url }} | ||
| GITHUB_REPOSITORY: ${{ github.repository }} |
Contributor
There was a problem hiding this comment.
Nit: sort this list alphabetically.
Collaborator
Author
There was a problem hiding this comment.
They are sorted in order in which they are used later, which I think is also fine :)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.