Skip to content

Add rippled-tools image containing Prettier for file formatting#32

Merged
bthomee merged 6 commits intomainfrom
bthomee/prettier
Aug 15, 2025
Merged

Add rippled-tools image containing Prettier for file formatting#32
bthomee merged 6 commits intomainfrom
bthomee/prettier

Conversation

@bthomee
Copy link
Contributor

@bthomee bthomee commented Aug 11, 2025

To avoid having to set up Node.JS, NPM, and install Prettier from scratch each time, this PR creates a new tools-rippled-prettier image with everything already configured.

See XRPLF/rippled#5665 for where it will be used.

@bthomee bthomee requested a review from Bronek August 11, 2025 21:44
@Bronek
Copy link
Collaborator

Bronek commented Aug 12, 2025

Any chance you could do this with pnpm ? Asking because I think that's the only NPM package manager supporting lockfiles, and a lockfile seem an important security feature, given that NPM has pretty poor security by itself. For reference:

@mvadari
Copy link

mvadari commented Aug 12, 2025

npm also supports lockfiles

@bthomee
Copy link
Contributor Author

bthomee commented Aug 14, 2025

I propose doing more rigorous locking in a follow-up PR, if at all, especially since this Docker image will only be used to run on PR commits but not on PR merges.

@bthomee bthomee merged commit 2050685 into main Aug 15, 2025
7 checks passed
@bthomee bthomee deleted the bthomee/prettier branch August 15, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants