Combines clang-format and prettier into a single pre-commit image#46
Merged
Combines clang-format and prettier into a single pre-commit image#46
Conversation
9 tasks
Bronek
reviewed
Aug 21, 2025
| echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_VERSION%%.*}.x nodistro main" | \ | ||
| tee /etc/apt/sources.list.d/nodesource.list | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends nodejs=${NODE_VERSION}-1nodesource1 |
Collaborator
There was a problem hiding this comment.
This is so much better than e.g. curl https:// . . . . | bash which I think was used to install NVM. Nice, and I am glad it works !
Bronek
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us create a single pre-commit job that simply runs
pre-commit run --show-diff-on-failure --color=always --all-files.This change here uses Nodesource to install Node, instead of NVM - this time GitHub CI is able to run prettier without problems.