Skip to content

fix: Start without cache file#2976

Merged
kuznetsss merged 17 commits intoXRPLF:developfrom
kuznetsss:Fix_startup_without_cache_file
Mar 6, 2026
Merged

fix: Start without cache file#2976
kuznetsss merged 17 commits intoXRPLF:developfrom
kuznetsss:Fix_startup_without_cache_file

Conversation

@kuznetsss
Copy link
Collaborator

#2830 introduced a bug that clio couldn't start without having a cache file. This PR fixes the problem.

@kuznetsss kuznetsss force-pushed the Fix_startup_without_cache_file branch from 0a9ca8d to 43c1cf2 Compare March 6, 2026 12:02
@kuznetsss kuznetsss force-pushed the Fix_startup_without_cache_file branch from 761617b to 870d7aa Compare March 6, 2026 12:29
@kuznetsss kuznetsss requested a review from godexsoft March 6, 2026 12:40
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.71%. Comparing base (3737459) to head (8343bbd).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/etl/CacheLoader.hpp 72.72% 1 Missing and 2 partials ⚠️
src/cluster/WriterDecider.cpp 88.88% 0 Missing and 2 partials ⚠️
src/app/ClioApplication.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2976      +/-   ##
===========================================
- Coverage    81.76%   81.71%   -0.05%     
===========================================
  Files          391      391              
  Lines        15656    15670      +14     
  Branches      8334     8340       +6     
===========================================
+ Hits         12801    12805       +4     
- Misses        1655     1664       +9     
- Partials      1200     1201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Overall looks good! 👍

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuznetsss kuznetsss merged commit 05e52ee into XRPLF:develop Mar 6, 2026
26 checks passed
@kuznetsss kuznetsss deleted the Fix_startup_without_cache_file branch March 6, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants