add default ordering to issuer_nf_tokens_v2#588
Merged
godexsoft merged 3 commits intoXRPLF:developfrom Apr 7, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #588 +/- ##
===========================================
- Coverage 17.48% 17.48% -0.01%
===========================================
Files 138 138
Lines 9718 9719 +1
Branches 6025 6026 +1
===========================================
Hits 1699 1699
- Misses 6438 6439 +1
Partials 1581 1581 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
godexsoft
requested changes
Apr 7, 2023
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
The alignment is all messed up now, please fix 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title says it all. adding this ordering shouldn't actually be strictly necessary since I've just specified what is the default ordering anyway (which is what we want). however, I think adding it adds to the clarity of what we're doing here.
Fix #589