Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #656 +/- ##
===========================================
- Coverage 24.99% 24.98% -0.02%
===========================================
Files 130 130
Lines 8799 8799
Branches 5219 5220 +1
===========================================
- Hits 2199 2198 -1
Misses 4546 4546
- Partials 2054 2055 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of return "invalidParam" error_code + "invalidHotWallet" error_message, we shall return "invalidHotWallet" as error_code. Rippled does not have such error_code, it just assigns the json directly.
Clio creates the "invalidHotWallet" in this PR, Fix #654