Merged
Conversation
cindyyan317
commented
Jun 5, 2023
cindyyan317
commented
Jun 5, 2023
cindyyan317
commented
Jun 5, 2023
cindyyan317
commented
Jun 5, 2023
Codecov Report
@@ Coverage Diff @@
## develop #667 +/- ##
===========================================
+ Coverage 30.23% 31.09% +0.86%
===========================================
Files 140 149 +9
Lines 7436 7892 +456
Branches 4422 4683 +261
===========================================
+ Hits 2248 2454 +206
- Misses 3109 3145 +36
- Partials 2079 2293 +214 |
godexsoft
requested changes
Jun 5, 2023
Collaborator
godexsoft
left a comment
There was a problem hiding this comment.
Leaving a few comments 👍
Overall looks good but needs a few tweaks here and there:
- remove most one line comments that are straight up useless and/or come from examples of asio
- Use doxygen comments to document what member functions do as well as on top of classes to briefly describe what they are for.
godexsoft
requested changes
Jun 6, 2023
Collaborator
godexsoft
left a comment
There was a problem hiding this comment.
Adding a few more comments and questions 👍 I think we are very close to merging this 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 Separate web server with RPC. Web server becomes more generic.
2 Expand the WsBase to ConnectionBase, both RPC Executor and SubscriptionManager will send the response via ConnectionBase.
3 Add unittests
4 Add some logs