Skip to content

Subscribe ReportingNotSupported error#682

Merged
cindyyan317 merged 1 commit intoXRPLF:developfrom
cindyyan317:sub_error
Jun 9, 2023
Merged

Subscribe ReportingNotSupported error#682
cindyyan317 merged 1 commit intoXRPLF:developfrom
cindyyan317:sub_error

Conversation

@cindyyan317
Copy link
Contributor

@cindyyan317 cindyyan317 commented Jun 9, 2023

Rippled's reporting mode returns "ReportingNotSupported" for "peer_status" and "consensus" streams while clio returns streamMalformed like other invalid stream name.

This PR is to add ReportingNotSupported error for "peer_status" and "consensus"
#678 #679

@cindyyan317 cindyyan317 requested a review from godexsoft June 9, 2023 11:42
@cindyyan317 cindyyan317 marked this pull request as ready for review June 9, 2023 11:42
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #682 (7cbeec7) into develop (b873af2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #682      +/-   ##
===========================================
+ Coverage    31.42%   31.43%   +0.01%     
===========================================
  Files          149      149              
  Lines         7893     7896       +3     
  Branches      4680     4682       +2     
===========================================
+ Hits          2480     2482       +2     
  Misses        3116     3116              
- Partials      2297     2298       +1     

see 1 file with indirect coverage changes

@cindyyan317 cindyyan317 merged commit 9d28e64 into XRPLF:develop Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants