Fix mismatch : subscribe book offers when both is true#684
Merged
cindyyan317 merged 1 commit intoXRPLF:developfrom Jun 12, 2023
Merged
Fix mismatch : subscribe book offers when both is true#684cindyyan317 merged 1 commit intoXRPLF:developfrom
cindyyan317 merged 1 commit intoXRPLF:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no document regarding this.
According to rippled's code,
When snapshot is true, we should return the list of the current offers.
When both is false, these offers put into offers field
When both is true, the original book's offers go to the 'bids' field, the reversed book's offers go to the 'asks' field.
'offers' will be present if any book in subscribed book list has snapshot being true but both being false.
'bids' 'asks' will be present if any book in subscribed book list has snapshot being true and both being true.