Skip to content

Stop etl when crash#708

Merged
cindyyan317 merged 4 commits intoXRPLF:developfrom
cindyyan317:stop_etl_when_crash
Jun 21, 2023
Merged

Stop etl when crash#708
cindyyan317 merged 4 commits intoXRPLF:developfrom
cindyyan317:stop_etl_when_crash

Conversation

@cindyyan317
Copy link
Contributor

No description provided.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small suggestions 👍

@cindyyan317 cindyyan317 marked this pull request as ready for review June 21, 2023 10:02
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@557ea5d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #708   +/-   ##
==========================================
  Coverage           ?   33.36%           
==========================================
  Files              ?      154           
  Lines              ?     7964           
  Branches           ?     4718           
==========================================
  Hits               ?     2657           
  Misses             ?     2811           
  Partials           ?     2496           

@cindyyan317 cindyyan317 requested a review from godexsoft June 21, 2023 10:23
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cindyyan317 cindyyan317 merged commit d9e8974 into XRPLF:develop Jun 21, 2023
godexsoft added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants