account_object supports nft page#736
Merged
cindyyan317 merged 5 commits intoXRPLF:developfrom Jul 10, 2023
Merged
Conversation
cindyyan317
force-pushed
the
nft_page
branch
5 times, most recently
from
9cff767 to
b4c2778
Compare
cindyyan317
commented
Jul 7, 2023
cindyyan317
commented
Jul 7, 2023
godexsoft
requested changes
Jul 7, 2023
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
Very cool! leaving just a few small suggestions for readability improvements. Everything else looks good to me 🚀
Codecov Report
@@ Coverage Diff @@
## develop #736 +/- ##
===========================================
+ Coverage 34.42% 34.55% +0.13%
===========================================
Files 158 158
Lines 8169 8198 +29
Branches 4783 4804 +21
===========================================
+ Hits 2812 2833 +21
+ Misses 2811 2810 -1
- Partials 2546 2555 +9 |
godexsoft
requested changes
Jul 10, 2023
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
Found a small inconsistency. Other than that it looks good. Let's finish this 👍
godexsoft
approved these changes
Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.