draft: New allow_private_endpoints stanza
#5309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5309 +/- ##
=======================================
Coverage 78.1% 78.1%
=======================================
Files 790 790
Lines 67907 67916 +9
Branches 8225 8218 -7
=======================================
+ Hits 53032 53056 +24
+ Misses 14875 14860 -15
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
|
Some commits are not signed. You need to rebase and sign every commit. |
vlntb
reviewed
Mar 12, 2025
| run("new in 100/out 10", {}, 100, 10, 4000, 10, 100, 6); | ||
| run("new in 0/out 10", {}, 0, 10, 4000, 10, 0, 1); | ||
| run("new in 100/out 10, private", {}, 100, 10, 0, 10, 0, 6); | ||
| auto testcases = { |
Collaborator
There was a problem hiding this comment.
Good job re-writing that!
The code is much easier to read.
vlntb
reviewed
Mar 12, 2025
src/xrpld/peerfinder/detail/Logic.h
Outdated
| if (!is_valid_address(ep.address)) | ||
| // Discard invalid addresses and if we don't support private IPs in | ||
| // Endpoint message | ||
| if (!is_valid_address(ep.address) || |
Collaborator
There was a problem hiding this comment.
[nit]: Consider breaking this into two checks to have two separate debug messages: one for invalid address and the other for !config_.allowPrivateEndpoints && !is_public(ep.address) case.
adds allow_private_endpoints configuration formatting issues clang formatting one more attempt to please clang
Tapanito
force-pushed
the
feature/private-network
branch
from
88120e7 to
e061b43
Compare
bthomee
approved these changes
May 27, 2025
Tapanito
changed the title
allow_private_endpoints stanzaallow_private_endpoints stanza
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Adds a new config stanza
allow_private_endpoints. The new config option allows servers to accept and advertise open slots for servers with private IP addresses.Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)