-
Notifications
You must be signed in to change notification settings - Fork 1.6k
refactor: Replace static_cast by (un)safe_cast wherever possible. #5319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bthomee/quality #5319 +/- ##
===============================================
Coverage 78.2% 78.2%
===============================================
Files 790 790
Lines 67725 67725
Branches 8175 8175
===============================================
+ Hits 52945 52947 +2
+ Misses 14780 14778 -2
🚀 New features to boost your workflow:
|
1 task
Collaborator
Author
|
We'll use automated tools to identify and, hopefully, fix these issues by running as pre-commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change replaces all
static_castbysafe_castorunsafe_castwherever possible.Context of Change
The intention of the
safe_castandunsafe_castfunctions is mainly for developers. It allows you to see at a glance if you have to worry about overflows and similar issues. They are also a great shortcut for casting enums. The functions are only for integral types for now, but they could be extended to cover other types in the future.The change in this PR:
static_castcalls bysafe_castcalls.safe_casttounsafe_castor otherwise tostatic_castif building failed.Type of Change