fix: Stdcoroutine-5: Fix TSAN issues#6525
Draft
pratikmankawde wants to merge 1 commit intopratik/std-coro/cleanup-boost-coroutinefrom
Draft
fix: Stdcoroutine-5: Fix TSAN issues#6525pratikmankawde wants to merge 1 commit intopratik/std-coro/cleanup-boost-coroutinefrom
pratikmankawde wants to merge 1 commit intopratik/std-coro/cleanup-boost-coroutinefrom
Conversation
5bc7cd5 to
dec5ced
Compare
55e2ad4 to
5e00517
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pratik/std-coro/cleanup-boost-coroutine #6525 +/- ##
=========================================================================
Coverage ? 81.4%
=========================================================================
Files ? 998
Lines ? 74511
Branches ? 7564
=========================================================================
Hits ? 60677
Misses ? 13834
Partials ? 0
🚀 New features to boost your workflow:
|
9083892 to
6c23459
Compare
3761a3e to
fb18c3a
Compare
cbfcec4 to
e28142b
Compare
68cb01a to
a867091
Compare
4 tasks
e28142b to
669c6fc
Compare
89c7c57 to
0b9a11e
Compare
669c6fc to
9473bfe
Compare
0b9a11e to
4919653
Compare
- Fix TSAN data races in CoroTaskRunner (atomic operations, mutex guards) - Enable TSAN CI builds with proper ucontext support - Add TSAN suppressions for pre-existing rippled issues - Remove -fno-pie flags for sanitizer compatibility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9473bfe to
b53df32
Compare
4919653 to
01fe13d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsan.supp: remove all rippled-code suppressions (races in our code should be fixed, not suppressed), keep only third-party/tooling suppressions (Boost, stdlib, TSAN internals).Context
This is a child PR of #6429 (
pratik/std-coro/cleanup-boost-coroutine).The TSAN SEGV crashes were caused by combining TSAN and UBSAN in the same build — their shadow memory regions collide on large binaries like
xrpld. Separating them resolves the immediate crash.Test plan