Skip to content

chore: Upgrade mako version#7108

Merged
bthomee merged 1 commit into
developfrom
a1q123456/upgrade-mako
May 11, 2026
Merged

chore: Upgrade mako version#7108
bthomee merged 1 commit into
developfrom
a1q123456/upgrade-mako

Conversation

@a1q123456
Copy link
Copy Markdown
Contributor

@a1q123456 a1q123456 commented May 11, 2026

High Level Overview of Change

This PR upgrades mako to a later version to avoid the security vulnerability.

Context of Change

Mako 1.2 has a know vulnerability issue GHSA-v973-fxgf-6xhp, which is addressed by 1.2.2.

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

@a1q123456 a1q123456 requested a review from bthomee May 11, 2026 14:40
@a1q123456 a1q123456 added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label May 11, 2026
@a1q123456 a1q123456 changed the title Patch commit for: 0198d861cb89a84a8722e9556e1b4145 chore: Upgrade mako version May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (779b49c) to head (8e59091).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7108     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76070   76070             
  Branches      7381    7376      -5     
=========================================
- Hits         62457   62436     -21     
- Misses       13613   13634     +21     

see 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee added this pull request to the merge queue May 11, 2026
Merged via the queue into develop with commit a761b0d May 11, 2026
59 of 64 checks passed
@bthomee bthomee deleted the a1q123456/upgrade-mako branch May 11, 2026 16:57
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants