feat: Enable and rename fixSecurity3_1_3 to fixCleanup3_1_3#7128
Merged
Conversation
Apply changes from xrpld-private PR #89: flip fixCleanup3_1_3 from Supported::no/DefaultNo to Supported::yes/DefaultYes and rename to better reflect cleanup nature. Includes TxQ queue-size assertion stabilisation and PerfLog test fixture cleanup.
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
bthomee
approved these changes
May 12, 2026
Change `constexpr std::size_t initQueueMax` to `std::size_t const initQueueMax` to fix clang-tidy readability-identifier-naming error. The constexpr naming convention requires `kUPPER_CASE` prefix, but as a local const the camelBack style is correct and consistent with other `initQueueMax` declarations in the same file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7128 +/- ##
=========================================
- Coverage 82.2% 82.2% -0.0%
=========================================
Files 1010 1010
Lines 76147 76147
Branches 7402 7372 -30
=========================================
- Hits 62564 62557 -7
- Misses 13583 13590 +7
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
approved these changes
May 12, 2026
bthomee
added
the
Ready to merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip
fixCleanup3_1_3fromSupported::no/VoteBehavior::DefaultNotoSupported::yes/VoteBehavior::DefaultYes, and rename to better reflect the cleanup nature.This change includes TxQ queue-size assertion stabilisation and PerfLog test fixture cleanup.