Skip to content

refactor: Clean up comments post-clang-tidy changes#7283

Merged
bthomee merged 4 commits into
developfrom
mvadari/fix-tidy-stuff
May 15, 2026
Merged

refactor: Clean up comments post-clang-tidy changes#7283
bthomee merged 4 commits into
developfrom
mvadari/fix-tidy-stuff

Conversation

@mvadari
Copy link
Copy Markdown
Collaborator

@mvadari mvadari commented May 15, 2026

High Level Overview of Change

This PR mostly fixes old variable names in comments, but also renames some variables to be more descriptive.

No functionality changes, mostly just comment changes but all source code changes are pure refactors.

Context of Change

General cleanup, pulled out of #6620

API Impact

N/A

@mvadari mvadari requested review from Copilot and godexsoft May 15, 2026 21:37
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label May 15, 2026
Comment thread include/xrpl/protocol/detail/ledger_entries.macro Outdated

This comment was marked as resolved.

xrplf-ai-reviewer[bot]

This comment was marked as resolved.

@mvadari mvadari requested a review from bthomee May 15, 2026 21:47
xrplf-ai-reviewer[bot]

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (6809690) to head (9d370c9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7283   +/-   ##
=======================================
  Coverage     82.1%   82.1%           
=======================================
  Files         1010    1010           
  Lines        76151   76151           
  Branches      7415    7414    -1     
=======================================
  Hits         62489   62489           
  Misses       13662   13662           
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp 92.5% <ø> (ø)
src/libxrpl/ledger/helpers/TokenHelpers.cpp 95.4% <ø> (ø)
src/libxrpl/tx/Transactor.cpp 90.4% <ø> (ø)
...rc/libxrpl/tx/transactors/delegate/DelegateSet.cpp 100.0% <ø> (ø)
src/libxrpl/tx/transactors/dex/AMMVote.cpp 98.3% <100.0%> (ø)
src/libxrpl/tx/transactors/lending/LoanPay.cpp 94.6% <ø> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 69.8% <ø> (ø)
src/xrpld/app/misc/detail/TxQ.cpp 97.1% <ø> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 15, 2026
@bthomee bthomee added this pull request to the merge queue May 15, 2026
Merged via the queue into develop with commit c7ecfc6 May 15, 2026
37 checks passed
@bthomee bthomee deleted the mvadari/fix-tidy-stuff branch May 15, 2026 23:29
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants