perf: Optimize MPT freeze checks to reduce redundant state reads#7411
Open
gregtatcam wants to merge 1 commit into
Open
perf: Optimize MPT freeze checks to reduce redundant state reads#7411gregtatcam wants to merge 1 commit into
gregtatcam wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7411 +/- ##
=========================================
- Coverage 82.4% 82.4% -0.0%
=========================================
Files 1011 1011
Lines 76547 76942 +395
Branches 7326 8965 +1639
=========================================
+ Hits 63065 63365 +300
- Misses 13482 13568 +86
- Partials 0 9 +9
🚀 New features to boost your workflow:
|
a2311f2 to
df0ed95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Optimize MPT freeze checks with existing token SLEs
Avoid redundant MPToken lookups in MPT freeze checks when callers already
have the holder MPToken SLE. Add SLE-based isFrozen(), isGlobalFrozen(),
and isIndividualFrozen() overloads, and reuse the loaded issuance SLE when
checking vault pseudo-account freeze state.
This reduces repeated state reads on mixed MPT/IOU payment paths while
preserving the existing MPTIssue fallback behavior.
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)