fix: nil pointer dereference in ScanTLS when no cert has DNSNames#40
Merged
Conversation
Member
|
Thanks for your fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
PROBLEM
ScanTLS panics with a
nilpointer dereference when none of the peer certificates contain DNSNames (e.g. certificates that only useSubject.CommonName).ROOT CAUSE
leaf was declared as
var leaf *x509.Certificateand only assigned inside the loop if a certificate had DNSNames. If no such certificate existed,leafremainednil. It was then unconditionally dereferenced in the slog call at the end of the function, even for non-feasible hosts.FIX
Initialize
leafto the first certificate before the loop and override it with the first certificate that has DNSNames if one is found.