XHTTP transport: Reduce memory allocations ~88% (68MB→~8MB per 10MB traffic)#5808
Closed
XHTTP transport: Reduce memory allocations ~88% (68MB→~8MB per 10MB traffic)#5808
Conversation
…raffic) Fixes excessive memory usage that causes iOS to kill VPN extensions (>50MB limit). Four targeted optimizations with minimal code changes: 1. hub.go: Pre-allocate body read buffer using known Content-Length instead of io.ReadAll grow-and-copy (77% of allocations) 2. hub.go: Skip slices.Concat when payload comes from single source (90%+ cases) 3. client.go: Pre-size bytes.Buffer for HTTP/1.1 request serialization 4. mux.go+dialer.go: Sweep dead entries from globalDialerMap to prevent unbounded growth Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
dup |
Contributor
Author
RPRX
pushed a commit
that referenced
this pull request
Mar 21, 2026
Member
|
c1b67a9 加了 co-author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Relates to #5344. XHTTP transport allocates ~7x more memory than data volume (10MB traffic → ~68MB allocations). On iOS, the system kills VPN extensions at >50MB. These 4 targeted fixes bring
allocations down to ~8MB with a minimal 39-line diff.
Test plan