Code simplification and fixes + ChatCard CSS fix#288
Merged
ClipplerBlood merged 3 commits intoXacus:masterfrom Jan 11, 2026
Merged
Code simplification and fixes + ChatCard CSS fix#288ClipplerBlood merged 3 commits intoXacus:masterfrom
ClipplerBlood merged 3 commits intoXacus:masterfrom
Conversation
juanferrer
approved these changes
Jan 10, 2026
Contributor
juanferrer
left a comment
juanferrer
left a comment
There was a problem hiding this comment.
Looks good. Some ideas for the future.
| // Embedded function | ||
| async function setBoonsForDarkMagicSpells() { | ||
| // Demon Lord page 111 | ||
| const DARK_MAGIC_TRADITIONS = ['Blood', 'Curse', 'Death', 'Demonology', 'Forbidden', 'Necromancy', 'Madness'] |
Contributor
There was a problem hiding this comment.
Fine for now, but it doesn't support traditions from other books nor custom traditions. In the future we could add an isDarkMagic flag to SpellDataModel and check it when going through the spells below.
| switch (text) { | ||
| const targetNumber = game.settings.get('demonlord', 'optionalRuleDieRollsMode') === 'b' ? 11 : 10 | ||
|
|
||
| switch (mode) { |
Contributor
There was a problem hiding this comment.
Nice, easily extendable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.