Fixed null pointer exceptions caused by missing or broken configuration file#48
Closed
GideonLeGrange wants to merge 1 commit into
Closed
Fixed null pointer exceptions caused by missing or broken configuration file#48GideonLeGrange wants to merge 1 commit into
GideonLeGrange wants to merge 1 commit into
Conversation
GideonLeGrange
changed the title
SidneyAllen
added a commit
that referenced
this pull request
Sep 22, 2017
Contributor
|
Tested successfully and merged - thank you! |
SidneyAllen
added a commit
that referenced
this pull request
Sep 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two related problems:
To fix this, I introduce a new exception
XeroClientException. I did not want to re-useXeroApiExceptionsince this is thrown on failures which happen before the remote API is called.XeroClientExceptionextendsRuntimeExceptionso there should be no impact on backwards compatibility.