Skip to content

Change publish conditions to check for changes#658

Merged
ryanNexus merged 1 commit into
XeroAPI:masterfrom
simonsabin:patch-1
Jun 25, 2026
Merged

Change publish conditions to check for changes#658
ryanNexus merged 1 commit into
XeroAPI:masterfrom
simonsabin:patch-1

Conversation

@simonsabin

Copy link
Copy Markdown
Contributor

Looking to fix #640

Can't test as it requires greater priviledges

Copilot AI review requested due to automatic review settings June 19, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OAuth2Client NuGet publishing GitHub Actions workflow to gate publish-related steps based on the “changes detected” check, aligning the step conditions with the workflow’s actual check_changes output so the publish path can run when OAuth2Client files change (Issue #640).

Changes:

  • Switches publish-step if: conditions from a non-existent steps.calc_version.outputs.should_publish output to steps.check_changes.outputs.has_changes.
  • Ensures build/pack/push/tag steps are consistently conditioned on the same “has changes” signal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanNexus ryanNexus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@ryanNexus ryanNexus merged commit e2b29f7 into XeroAPI:master Jun 25, 2026
1 check passed
@simonsabin simonsabin deleted the patch-1 branch June 26, 2026 07:50
@simonsabin

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHUb Action to publish Oauth2Client isn't working

3 participants