fix: remove invalid UpdateTooltip script handler on Button frames

[Xerrion]

What

Remove SetScript("UpdateTooltip", ...) calls on Button frames in RollFrame.lua and LootFrame.lua.

UpdateTooltip is not a valid script handler for Button frames - it only exists on GameTooltip. Setting it on a Button caused the crash:

Button:GetScript(): Doesn't have a "UpdateTooltip" script

Changes

• RollFrame.lua: Removed btn:SetScript("UpdateTooltip", OnIconEnter) from CreateRollIcon
• LootFrame.lua: Removed 3 slot:SetScript("UpdateTooltip", OnSlotUpdateTooltip) calls and the now-dead OnSlotUpdateTooltip function

Tooltip behavior is unchanged - OnEnter/OnLeave handlers handle all tooltip display correctly.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Testing

• luacheck . passes with 0 new warnings

Summary by CodeRabbit

• Refactor
  • Simplified internal tooltip handling by removing redundant code. Tooltip functionality remains unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e6734cbd-6515-4db3-ae2b-dbc56901827c

📥 Commits

Reviewing files that changed from the base of the PR and between d614aa2 and f84f21d.

📒 Files selected for processing (2)

• DragonLoot/Display/LootFrame.lua
• DragonLoot/Display/RollFrame.lua

💤 Files with no reviewable changes (2)

• DragonLoot/Display/RollFrame.lua
• DragonLoot/Display/LootFrame.lua

---

📝 Walkthrough

Walkthrough

Removed legacy UpdateTooltip script assignments from LootFrame and RollFrame, consolidating tooltip behavior to explicit OnEnter/OnLeave handlers. The OnSlotUpdateTooltip function was entirely removed from LootFrame, while RollFrame had one script binding deleted.

Changes

Cohort / File(s)	Summary
Tooltip Handler Consolidation DragonLoot/Display/LootFrame.lua	Removed OnSlotUpdateTooltip function and three SetScript("UpdateTooltip", OnSlotUpdateTooltip) assignments from slot frame creation/release/rendering logic. Tooltip behavior now handled exclusively by explicit OnEnter/OnLeave handlers.
Tooltip Handler Consolidation DragonLoot/Display/RollFrame.lua	Removed SetScript("UpdateTooltip", OnIconEnter) assignment from CreateRollIcon. Icon tooltip behavior remains via explicit OnEnter→OnIconEnter and OnLeave→OnIconLeave handlers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

display

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title follows Conventional Commit format with valid type 'fix' and provides a clear, specific description of the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}