fix: resolve loot/roll frame animation jumping#60
Merged
Conversation
- Update embedded LibAnimate with conditional property scoping - LootAnimations: capture/restore visual state on animation interruption - RollAnimations: same capture/restore pattern for roll frames - LootFrame: guard LayoutSlots during close animation via isClosing flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the loot and roll frames visually "jumping" during open/close animations. Two root causes addressed:
Changes
Updated embedded LibAnimate
Synced from Xerrion/LibAnimate#58 - animations now only touch properties they define. Scale is relative to
originalScale.LootAnimations.lua
RestoreDbAnchorin closeonFinishedresets position for next open (important for slide animations)isClosingflag to prevent layout changes during close animationStopAllordering (beforeSetAlpha(0), not after)RollAnimations.lua
isClosingflag exported vians.RollAnimations.isClosingLootFrame.lua
UpdateSlotguardsLayoutSlots()withisClosingcheck to prevent mid-close-animation resizingTesting
/dl test- frame should open at correct scale throughout animation (no jump)/dl testroll- roll frames animate without scale jumping