Skip to content

feat(localization): add Simplified Chinese (zhCN) translations, Notes, Category#143

Merged
Xerrion merged 4 commits into
Xerrion:masterfrom
7peanuts:master
Mar 28, 2026
Merged

feat(localization): add Simplified Chinese (zhCN) translations, Notes, Category#143
Xerrion merged 4 commits into
Xerrion:masterfrom
7peanuts:master

Conversation

@7peanuts
Copy link
Copy Markdown
Contributor

@7peanuts 7peanuts commented Mar 27, 2026

Description

Update zhCN localization, Notes, Category

Type of Change

  • Documentation update

Checklist

  • My code follows the project's code style (4-space indent, 120 char lines)
  • I have tested my changes in-game
  • Luacheck reports no warnings
  • My commits follow conventional commit format

Summary by CodeRabbit

  • New Features
    • Full Simplified Chinese localization added: localized add-on metadata, complete UI translations for notifications, toasts, messages, mail, filters, appearance and animation controls, options tabs, and profile management.

@7peanuts 7peanuts requested a review from Xerrion as a code owner March 27, 2026 03:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8a2ff68b-eda7-4b54-b5ad-8ed98c1e9f61

📥 Commits

Reviewing files that changed from the base of the PR and between 89b6910 and 1ec517c.

📒 Files selected for processing (1)
  • DragonToast/Locales/zhCN.lua
✅ Files skipped from review due to trivial changes (1)
  • DragonToast/Locales/zhCN.lua

📝 Walkthrough

Walkthrough

Added Simplified Chinese localization: TOC metadata gained ## Notes-zhCN and ## Category-zhCN, and the zhCN.lua locale file was populated with ~236 Simplified Chinese translation entries for UI, messages, toasts, mail, and options.

Changes

Cohort / File(s) Summary
TOC Metadata Localization
DragonToast/DragonToast.toc
Added ## Notes-zhCN and ## Category-zhCN metadata fields for Simplified Chinese description and category.
Locale Translations
DragonToast/Locales/zhCN.lua
Replaced placeholder with ~236 Simplified Chinese locale key/value entries covering core addon text, toast labels, roll states, mail/listener strings, and extensive options UI strings across General, Filters, Display, Animation, Appearance, and Profiles.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title follows Conventional Commit format (type(scope): description) with valid type 'feat' and scope 'localization', accurately summarizing the main changes to add Simplified Chinese translations and metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Xerrion
Copy link
Copy Markdown
Owner

Xerrion commented Mar 27, 2026

Hey @7peanuts - welcome, and thank you for this! 🎉

This is the first community contribution to DragonToast, and I'm genuinely happy it's a high-quality localization. The Simplified Chinese translations look solid - clean, accurate, and complete. Really appreciate you taking the time to do this.

A couple of things before I can merge:

PR title and commit messages

I use Conventional Commits across the project so that the changelog and releases are generated automatically. The PR title and commit messages need to follow that format to get picked up properly.

For the PR title, something like:

feat(localization): add Simplified Chinese (zhCN) translations

And for the commits, prefix them with feat: or docs: as appropriate. The repo does squash merges, so the PR title is what matters most - but clean commit messages are still good practice.

Minor fix

zhCN.lua is missing a trailing newline at the end of the file. Small thing, easy fix.

Heads up - incoming rebase

I'm preparing a refactor PR that will change the locale key format across the codebase. Once that merges, you'll need to rebase this branch on top of it. The good news is your translations are already in the correct format, so the rebase should be straightforward - mostly just resolving the key renames in the base files, not your actual translation work.

I'll ping you here when that lands.

Thanks again for contributing - looking forward to getting this merged! 🐉

@7peanuts 7peanuts changed the title Update zhCN localization, Notes, Category feat(localization): add Simplified Chinese (zhCN) translations, Notes, Category Mar 28, 2026
@7peanuts
Copy link
Copy Markdown
Contributor Author

Ok, done.

@Xerrion Xerrion merged commit 572cebe into Xerrion:master Mar 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants