fix: guard OnToastFinished in OnLeave against active lifecycle phases (#171)

[Xerrion]

What

Toasts were vanishing instantly when the cursor hovered during the attention animation phase (the quality-gated bounce/pulse before the hold timer).

Root Cause

In OnLeave, the fallback OnToastFinished(self) fired whenever resumed == false. During the attention phase, _isHovered is set to true on enter but nothing is actually paused - LibAnimate keeps running. On leave, ResumeFromHoverHold returns false (the _hoverHoldCallback is only set during the hold phase), so resumed stayed false and the toast was force-finished immediately.

Fix

Added and self._phase == nil and not self._isExiting to the fallback guard. OnToastFinished is now only called from OnLeave as a last resort when the lifecycle has genuinely stalled (no active phase, not currently exiting). If _phase is set, the LibAnimate queue is still running and will call OnToastFinished naturally via its own onFinished callback.

Changes

• DragonToast/Display/ToastFrame.lua: Two-predicate guard added to OnLeave fallback

Type of change

• Bug fix (non-breaking change which fixes an issue)

Closes #171

[coderabbitai]

Warning

Rate limit exceeded

@Xerrion has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 38 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 38 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b3af643f-9bbb-4dd7-a491-86324d2042f3

📥 Commits

Reviewing files that changed from the base of the PR and between b02e44b and eefa19a.

📒 Files selected for processing (1)

• DragonToast/Display/ToastFrame.lua

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}