fix: prevent anchor drift when animations complete with an onFinished callback

[Copilot]

When a queued animation completed, its state was cleared before the onFinished callback fired. The next Animate() call inside the callback found no active state, skipped Stop(), and called frame:GetPoint() while the frame was still at its final translated position — baking the translation offset into the new anchor. Each queue entry compounded the drift, causing frames to stack.

Changes

• LibAnimate.lua — completion handler: Defer lib.activeAnimations[frame] = nil until after onFinished fires for frames that have a callback.
  • Frames without a callback are still cleared immediately (no behaviour change).
  • After the callback returns, the state is cleared only if the callback did not start a new animation (identity check: activeAnimations[frame] == state).

Keeping the completed state alive during the callback means Animate() → Stop() finds it, restores the frame to state.anchorX/Y, and frame:GetPoint() captures the correct base anchor.

-- Before: state wiped before callbacks fire
lib.activeAnimations[frame] = nil
-- ...fire callbacks (Stop() skipped, GetPoint() captures offset position)

-- After: state kept alive; Stop() inside callback restores base anchor first
-- ...fire callbacks (Stop() finds state, restores anchorX/Y correctly)
if lib.activeAnimations[cb.frame] == cb.state then
    lib.activeAnimations[cb.frame] = nil  -- clear only if callback didn't replace it
end

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• luarocks.org
  • Triggering command: /usr/bin/lua5.1 /usr/bin/lua5.1 /usr/bin/luarocks install luacheck (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Animation frames can get stuck on top of each other when queuing them too fast. Please find out where the problems are.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.