fix: standardize Ace3 embedded packaging paths#28
Conversation
📝 WalkthroughWalkthroughThis PR consolidates multiple Ace3 library dependencies into a single umbrella entry in the package metadata and removes conditional debug blocks from the library embeds configuration, while expanding the ignore list for build artifacts and documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.pkgmeta:
- Line 5: The referenced external "Libs/Ace3" in .pkgmeta currently points to
the mutable "trunk" URL; change it to a pinned tag or revision by replacing the
trunk reference with a specific tag field (e.g., set tag: to a fixed release
like "3.0.0-release" or a commit hash) so the externals entry for Libs/Ace3
becomes deterministic and reproducible; ensure the externals block for Libs/Ace3
includes the url and the new tag key and verify any tooling that consumes
.pkgmeta honors the tag field.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e04d501d-2943-4224-a24b-d69ebd151658
📒 Files selected for processing (2)
.pkgmetaLibs/embeds.xml
💤 Files with no reviewable changes (1)
- Libs/embeds.xml
Description
I standardized the embedded Ace3 packaging layout so release artifacts and local development use the same
Libs/Ace3/...structure.This removes the mixed library path strategy that could make packaged releases fail to load
CallbackHandler-1.0fromLibs/embeds.xml.Type of Change
Related Issues
No tracked issue - this fixes the packaged release warning reported during manual install testing.
Testing
luacheck .)git diff --checkpassesLibs/embeds.xmlparses successfullyChecklist
Summary by CodeRabbit