Skip to content

fix: standardize Ace3 embedded packaging paths#28

Merged
Xerrion merged 1 commit intomasterfrom
fix/ace3-packaging-paths
Mar 14, 2026
Merged

fix: standardize Ace3 embedded packaging paths#28
Xerrion merged 1 commit intomasterfrom
fix/ace3-packaging-paths

Conversation

@Xerrion
Copy link
Copy Markdown
Owner

@Xerrion Xerrion commented Mar 14, 2026

Description

I standardized the embedded Ace3 packaging layout so release artifacts and local development use the same Libs/Ace3/... structure.

This removes the mixed library path strategy that could make packaged releases fail to load CallbackHandler-1.0 from Libs/embeds.xml.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Refactor (non-breaking change that improves code quality)
  • Documentation update
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issues

No tracked issue - this fixes the packaged release warning reported during manual install testing.

Testing

  • Luacheck passes (luacheck .)
  • Tested in-game manually
  • WoW version(s) tested on: Not tested in-game
  • Reviewed only the intended packaging files
  • git diff --check passes
  • Libs/embeds.xml parses successfully
  • Packaged artifact smoke test completed

Checklist

  • My code follows the project's code style (4-space indent, 120 char lines)
  • I have tested my changes in-game
  • Luacheck reports no warnings
  • My commits follow conventional commit format

Summary by CodeRabbit

  • Chores
    • Streamlined dependency management and build configuration for improved maintainability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 14, 2026

📝 Walkthrough

Walkthrough

This PR consolidates multiple Ace3 library dependencies into a single umbrella entry in the package metadata and removes conditional debug blocks from the library embeds configuration, while expanding the ignore list for build artifacts and documentation.

Changes

Cohort / File(s) Summary
Package Configuration
.pkgmeta
Consolidated multiple Ace3 library externals (LibStub, CallbackHandler-1.0, AceAddon-3.0, AceConsole-3.0, AceEvent-3.0, AceDB-3.0) into a single Ace3 umbrella entry. Expanded ignore list to include README.md, .github, .gitignore, .release, \*.md (except CHANGELOG.md), .luacheckrc, tests, and release configuration files.
Library Embeds
Libs/embeds.xml
Removed debug and non-debug conditional block markers, retaining only debug-related Script/Include entries without wrapper markup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 With whiskers twitching, I hop around,
Ace3 bundled—one lib, profound!
Debug blocks cleared, embeds refined,
A cleaner package, wonderfully designed!
The warren cheers for this tidy delight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: standardize Ace3 embedded packaging paths' directly and accurately summarizes the main change: consolidating multiple Ace3 library externals into a single Ace3 umbrella entry and removing embedded library conditionals.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ace3-packaging-paths
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.pkgmeta:
- Line 5: The referenced external "Libs/Ace3" in .pkgmeta currently points to
the mutable "trunk" URL; change it to a pinned tag or revision by replacing the
trunk reference with a specific tag field (e.g., set tag: to a fixed release
like "3.0.0-release" or a commit hash) so the externals entry for Libs/Ace3
becomes deterministic and reproducible; ensure the externals block for Libs/Ace3
includes the url and the new tag key and verify any tooling that consumes
.pkgmeta honors the tag field.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e04d501d-2943-4224-a24b-d69ebd151658

📥 Commits

Reviewing files that changed from the base of the PR and between 462a88e and 19ca0de.

📒 Files selected for processing (2)
  • .pkgmeta
  • Libs/embeds.xml
💤 Files with no reviewable changes (1)
  • Libs/embeds.xml

Comment thread .pkgmeta
@Xerrion Xerrion merged commit ad3fff8 into master Mar 14, 2026
3 checks passed
@Xerrion Xerrion deleted the fix/ace3-packaging-paths branch March 14, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant