Skip to content

Clean CFLAGS-family and DEB_* environment before building the AMC firmware #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quetric merged 2 commits into from
May 7, 2026
+29 −1
Merged

Clean CFLAGS-family and DEB_* environment before building the AMC firmware #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aff1ea
Fix: unset cflags and other env variables set by the debian package flow
amd-vserbu Apr 24, 2026
461798e
Fix pep8 formatting on file
amd-vserbu May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion linker/slashkit/emit/hw/project_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,29 @@
AVED_DESIGN_NAME = "amd_v80_gen5x8_25.1"


# Host toolchain flags injected by dpkg-buildpackage (e.g. -mno-omit-leaf-frame-pointer,
# -fcf-protection, -fstack-clash-protection) are not understood by the arm-xilinx-eabi
# cross-compiler used for the AVED AMC firmware. Strip them before shelling out.
_CROSS_BUILD_ENV_BLOCKLIST = (
"CFLAGS",
"CXXFLAGS",
"CPPFLAGS",
"LDFLAGS",
"FFLAGS",
"FCFLAGS",
"OBJCFLAGS",
"OBJCXXFLAGS",
"GCJFLAGS",
"ASFLAGS",
)


def _clean_cross_build_env() -> dict[str, str]:
env = {k: v for k, v in os.environ.items()
if k not in _CROSS_BUILD_ENV_BLOCKLIST}
return {k: v for k, v in env.items() if not k.startswith("DEB_")}


def _copy_checked(src: Path, dest: Path) -> None:
if not src.exists():
raise FileNotFoundError(f"Expected file not found: {src}")
Expand Down Expand Up @@ -160,7 +183,12 @@ def generate_base_pdi_with_aved(config: CommandConfiguration) -> Path:
_copy_checked(in_path, target_dir / file_name)

logger.info("Running AVED build script in %s", aved_hw_dir)
subprocess.run(["bash", "build_all.sh"], cwd=str(aved_hw_dir), check=True)
subprocess.run(
["bash", "build_all.sh"],
cwd=str(aved_hw_dir),
env=_clean_cross_build_env(),
check=True,
)

aved_pdi = aved_hw_dir / f"{AVED_DESIGN_NAME}.pdi"
if not aved_pdi.exists():
Expand Down
Loading