Enable build of 06_dcmac example#81
Merged
Merged
Conversation
mariodruiz
approved these changes
May 7, 2026
Collaborator
|
@amd-vserbu, can you please review as well? |
|
Others example have: if(SLASH_USE_REPO)
get_filename_component(REPO_ROOT "${CMAKE_CURRENT_LIST_DIR}/../.." REALPATH)
list(APPEND CMAKE_MODULE_PATH "${REPO_ROOT}/cmake")
include(SlashTools)
add_subdirectory(${REPO_ROOT}/vrt ${CMAKE_CURRENT_BINARY_DIR}/vrt)
set(_VRT_INCLUDES /usr/include/ami)
set(_VRT_LIBS vrt ami)
else()
find_package(vrt REQUIRED CONFIG)
find_package(SlashTools REQUIRED)
set(_VRT_INCLUDES "")
set(_VRT_LIBS vrt::vrt ami)
endif()We would want that add_subdirectory(${REPO_ROOT}/vrt ${CMAKE_CURRENT_BINARY_DIR}/vrt)
set(_VRT_INCLUDES /usr/include/ami)
set(_VRT_LIBS vrt ami)section included as well the if branch so the example can be built using the SLASH_USE_REPO as well. Otherwise looks good. |
Author
|
Oh right, i didnt checked the ON path - i will update it as well |
Author
|
I added the changes, to enable USE_REPO=ON. I also set the CXX standard to 20, now its completely equivalent to the current state of the other examples. |
|
Looks good to me! |
Collaborator
|
@hpc-aulmamei can you merge? |
Collaborator
|
sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current version fails in finding SlashTools:
This commit adapts the CMakeLists.txt based on the 00_axilite example to reenable the build.
Also the provided host code is added as build target.