Conversation
added 2 commits
April 15, 2026 14:50
Signed-off-by: Prerona Dutta <predutta@xcopredutta50x.amd.com>
Signed-off-by: Prerona Dutta <predutta@xcopredutta50x.amd.com>
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving XRT/XDP user-facing warnings in AIE trace/profile plugins when xrt.ini AIE metric settings are missing, mis-specified, or use unsupported forms, aligning messages with the actual supported setting names.
Changes:
- Fixes warning text to reference the correct config keys (e.g.,
graph_based_*_tile_metrics,graph_based_interface_tile_metrics). - Expands “no counters / no valid metrics” guidance to include both graph-based and tile-based metric settings (and additional tile types).
- Adds new warnings for certain invalid
tile_based_interface_tile_metricsformats.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
profile/plugin/aie_trace/aie_trace_metadata.cpp |
Corrects setting name references and adds new warnings for invalid interface-tile metric lines. |
profile/plugin/aie_profile/ve2/aie_profile.cpp |
Improves “no counters found” warning to list supported metric settings more completely. |
profile/plugin/aie_profile/edge/aie_profile.cpp |
Improves “no valid metric setting” warning to list supported metric settings more completely. |
profile/plugin/aie_profile/aie_profile_metadata.cpp |
Corrects setting name references and adds new warnings for invalid interface-tile metric lines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixing the logic so that valid single-tile settings that include a channel (e.g. <col>:<metric>:<channel>) isn't considered error. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
In case second entry is not maxcolumn, we are giving error message by default whereas it could also be case three. Hence leaving it to be handled correctly in case three. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Avoiding redundant checks in pass three which have already been filtered out in pass two. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Prerona Dutta <predutta@xcopredutta50x.amd.com>
jvillarre
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that Improves XRT warnings when AIE profile settings are missing or mis-specified, and when tile_based_interface_tile_metrics in xrt.ini does not match the supported forms.
[CR-1242635] : Warning message incorrect when specifying kernel that does not exist for graph_based_memory_tile_metrics
[CR-1239757] : No warning message when using {,} tile based interface tile metric
[CR-1218626] : Warning message with board run when xrt.ini has AIE profiling but no metrics is missing some settings
[CR-1236200]: Invalid warning message when using channel specific tile based metrics