fix for CR-1254182 destroying the aied before destroying hwctx#9372
Merged
Conversation
Signed-off-by: Bikash Singha <bisingha@xcobisingha40x.xlnx.xilinx.com>
bisingha-xilinx
requested review from
chvamshi-xilinx and
stsoe
as code owners
chvamshi-xilinx
approved these changes
Oct 24, 2025
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
bisingha-xilinx
added a commit
to bisingha-xilinx/XRT
that referenced
this pull request
Oct 25, 2025
…Xilinx#9372) Signed-off-by: Bikash Singha <bisingha@xcobisingha40x.xlnx.xilinx.com> Co-authored-by: Bikash Singha <bisingha@xcobisingha40x.xlnx.xilinx.com> (cherry picked from commit d7e8b92) Signed-off-by: Bikash Singha <bisingha@xcobisingha40x.xlnx.xilinx.com>
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://jira.xilinx.com/browse/CR-1254182
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
The bug was hw context used to destroy earlier than the aied and it causes crash.
How problem was solved, alternative solutions (if any) and why they were rejected
Problem was solved by destroying the aied before hw context which guarantees to stop the thread running. it avoids thread to access illegal memory or any dangling pointers.
Risks (if any) associated the changes in the commit
n/a
What has been tested and how, request additional testing if necessary
Tested the given testcase in the mentioned CR.
Documentation impact (if any)
n/a