Add XRT_BUILD_NUMBER CMake variable for use by upstream builds #9507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream projects cannot set XRT_VERSION_PATCH directory as it is reset by project(xrt). Instead upstream builds sets XRT_BUILD_NUMBER which is then used here to explicitly set XRT_VERSION_PATCH. Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
added a commit
to stsoe/xdna-driver
that referenced
this pull request
Dec 15, 2025
- Xilinx/XRT#9507 Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
maxzhen
pushed a commit
to amd/xdna-driver
that referenced
this pull request
Dec 15, 2025
- Xilinx/XRT#9507 Signed-off-by: Soren Soe <2106410+stsoe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Upstream projects cannot set XRT_VERSION_PATCH directory as it is reset by project(xrt). Instead upstream builds sets XRT_BUILD_NUMBER which is then used here to explicitly set XRT_VERSION_PATCH.