Removing xdp subdirectory and replacing it with a submodule#9534
Merged
jvillarre merged 1 commit intoXilinx:masterfrom Jan 13, 2026
Merged
Removing xdp subdirectory and replacing it with a submodule#9534jvillarre merged 1 commit intoXilinx:masterfrom
jvillarre merged 1 commit intoXilinx:masterfrom
Conversation
Signed-off-by: Jason Villarreal <jason.villarreal@amd.com>
vipangul
approved these changes
Jan 9, 2026
Collaborator
Author
|
The clang-tidy is failing due to too many files changing. I have verified that the XDP repository and the code being removed is identical so I will merge even though clang-tidy failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This separates out the profiling/debug library source code and changes the src/runtime_src/xdp directory to a submodule of the XDP github repository. This will allow for more independent development of profiling/debug features.
Risks (if any) associated the changes in the commit
Changes to the debug/profiling code base to be pulled into XRT will require a pull request to update the submodule commit ID. The different builds of XRT will still pull the libraries as a submodule and continue to build the same shared object libraries so the expectation is packaging after build will be unaffected.