AIESW-28045 : Add internal hw ctx function to get QoS#9684
AIESW-28045 : Add internal hw ctx function to get QoS#9684stsoe merged 2 commits intoXilinx:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an internal helper to retrieve a hardware context’s QoS/config parameter map for internal consumers (notably XDP) to inspect the context configuration.
Changes:
- Added
hw_context_impl::get_qos_map()to return the context’s QoS/config map. - Exposed
xrt_core::hw_context_int::get_qos_map(const xrt::hw_context&)in the internal header and implemented it inxrt_hw_context.cpp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/runtime_src/core/common/api/xrt_hw_context.cpp |
Implements hw_context_impl::get_qos_map() and the xrt_core::hw_context_int::get_qos_map() wrapper. |
src/runtime_src/core/common/api/hw_context_int.h |
Declares the new internal exported get_qos_map() API for XDP/internal use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
clang-tidy review says "All clean, LGTM! 👍" |
rbramand-xilinx
force-pushed
the
userspace
branch
from
e0ba499 to
97bd642
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rbramand-xilinx
force-pushed
the
userspace
branch
from
97bd642 to
c19e4e9
Compare
Signed-off-by: rahul <rbramand@amd.com>
Signed-off-by: rahul <rbramand@amd.com>
rbramand-xilinx
force-pushed
the
userspace
branch
from
c19e4e9 to
349abcc
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Problem solved by the commit
Added internal hw ctx function to get QoS. This function will be used by XDP to check QoS of a ctx and apply changes.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Returning the QoS map from hw ctx using hw_context_int function
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Documentation impact (if any)
NA