Deprecate messages added for kernel, IP and buffer constructors#9744
Deprecate messages added for kernel, IP and buffer constructors#9744chvamshi-xilinx merged 1 commit intoXilinx:masterfrom
Conversation
Signed-off-by: karthik dmg <karthdmg@xcokarthdmg50x.amd.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
| /// Deprecated construtor for exclusive access | ||
| kernel(const xrt::device& device, const xrt::uuid& xclbin_id, const std::string& name, bool ex) | ||
| : kernel(device, xclbin_id, name, ex ? cu_access_mode::exclusive : cu_access_mode::shared) | ||
| {} | ||
| /// Deprecated constructor for exclusive access | ||
| kernel(const xrt::device& device, const xrt::uuid& xclbin_id, const std::string& name, bool ex); |
There was a problem hiding this comment.
Any reason for this change, Shouldn't this ctor be deprecated as well, e.g. calling the already deprecated ctor?
There was a problem hiding this comment.
added deprication warning for this. replaced an inline function with declaration. moved the implementation to cpp file. we are adding messages for declarations only to skip xrt build failures due to g++ build catching the exception.
There was a problem hiding this comment.
I see, so if this ctor was left as it was, then compilation including xrt_kernel.h would always issue warning regardless of whether the ctor was used or not. I can see that, it makes sense. Thanks!
stsoe
changed the title
|
@karthdmg-xilinx @chvamshi-xilinx |
@stsoe , Assigned it to @svup-xilinx . He will fix it. |
3 participants
Problem solved by the commit
Mark legacy XRT entry points as deprecated in favor of hw_context-based APIs where a replacement exists (xrt::kernel, xrt::ip, xrt::aie::buffer, xrt::aie::profiling,
and the xclDeviceHandle kernel overload).
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
old APIs are not getting depricate warnings.
How problem was solved, alternative solutions (if any) and why they were rejected
Mark legacy XRT entry points as deprecated in favor of hw_context-based APIs where a replacement exists (xrt::kernel, xrt::ip, xrt::aie::buffer, xrt::aie::profiling,
and the xclDeviceHandle kernel overload).
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
build a sample application that uses these ctors and verify the warning is logged
Documentation impact (if any)
None