Skip to content

xrt-smi code cleanup#9765

Open
aktondak wants to merge 3 commits intoXilinx:masterfrom
aktondak:AIESW-29548_code_cleanup
Open

xrt-smi code cleanup#9765
aktondak wants to merge 3 commits intoXilinx:masterfrom
aktondak:AIESW-29548_code_cleanup

Conversation

@aktondak
Copy link
Copy Markdown
Collaborator

@aktondak aktondak commented Apr 30, 2026

Problem solved by the commit

This PR is a code re-organizationa and cleanup. No new functional logic has been implementation/changed. Following are the changes made :

  • The shared SMI types/implementation moved out of flat core/common/smi.{h,cpp} into a dedicated core/common/smi/ tree with separate Alveo, and Ryzen pieces.
  • This PR also consolidates different copies of shim implementations into just 2 Alveo and Ryzen pieces, with core_common_smi_objects (plus core_smi_alveo_objects / core_smi_ryzen_objects) so xrt_coreutil and the right shims link the right object files instead of xdna/mcdm maintining their own source. This is done since we do not see a lot of difference between xrt-smi ryzen specific implementation on windows vs. linux, thus it makes sense for both to have common code. On similar lines, pcie and edge also now share a common config generation logic (smi_alveo.cpp/.h).
  • Platform-specific blobs smi_pcie, smi_edge, and the driver’s smi_xdna and smi_mcdm were removed(code change in XDNA and MCDM repos respectively) in favor of the shared headers/APIs and the Ryzen implementation under core/common/smi/.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

https://jira.xilinx.com/browse/AIESW-31768

How problem was solved, alternative solutions (if any) and why they were rejected)

Risks (if any) associated the changes in the commit

None. This code change is just a cleanup before further code changes are made to extend this functionality to global xrt-smi options required for https://jira.xilinx.com/browse/AIESW-29548

What has been tested and how, request additional testing if necessary

Tested on Linux. Works as expected.

Documentation impact (if any)

None

Signed-off-by: Akshay Tondak <aktondak@amd.com>
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@aktondak aktondak mentioned this pull request Apr 30, 2026
@aktondak
Copy link
Copy Markdown
Collaborator Author

The build currently fails as there there is an xdp dependency on smi.h which is failing due to path change. I've opened an xdp PR for this and will update the xdp submodule in XRT once reviews on this PR are done.
cc: @stsoe

Copy link
Copy Markdown
Collaborator

@stsoe stsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but may have ripple effects?

Comment thread src/runtime_src/core/common/smi/smi_alveo.cpp Outdated
Comment thread src/runtime_src/core/common/smi/smi_ryzen.h Outdated
@IshitaGhosh IshitaGhosh mentioned this pull request May 1, 2026
@aktondak aktondak requested a review from stsoe May 1, 2026 22:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants