[AIE2P] Implement build subvector with vsel #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martien-de-jong
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
andcarminati,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
niwinanto and
stephenneuendorffer
as code owners
martien-de-jong
force-pushed
the
kmuts.subvec-vsel
branch
2 times, most recently
from
87e866f to
c45d96b
Compare
Collaborator
There was a problem hiding this comment.
This is present in the other PR as well. I think we could assert that NumSubVectors > 1, otherwise buildUnmerge can crash in a strange way.
Collaborator
Author
There was a problem hiding this comment.
Agree, although It looks as if buildUnmerge has the same assert. That doesn't look like 'in a strange way' to me.
Collaborator
|
It would be nice to have some QoR numbers for this PR. |
khallouh
reviewed
Mar 3, 2025
khallouh
reviewed
Mar 3, 2025
khallouh
reviewed
Mar 3, 2025
martien-de-jong
force-pushed
the
kmuts.subvec-vsel
branch
from
c45d96b to
08fbf6f
Compare
mgehre-amd
added a commit
that referenced
this pull request
Aug 21, 2025
[AutoBump] Merge with fixes of fc11020 (Aug 29) (15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.