Prevent Dark Reader from double-darkening the dark theme#33
Merged
Conversation
Add color-scheme meta tag and dynamically manage darkreader-lock meta tag so browser extensions like Dark Reader detect native dark mode support and don't apply their own dark theme on top of ours. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents Dark Reader (and similar extensions) from applying an additional darkening layer on top of the app’s native dark theme by explicitly declaring dark-mode support and conditionally “locking” Dark Reader when dark mode is active.
Changes:
- Added
<meta name="color-scheme" content="light dark">to declare light/dark support to the browser. - Added
darkreader-lockmeta insertion to the inline boot script to avoid double-dark flicker on initial load. - Added
darkreader-lockmeta add/remove logic to the theme Pinia store to handle runtime theme toggles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/stores/theme.ts | Adds/removes a meta[name="darkreader-lock"] tag based on computed dark-mode state. |
| frontend/index.html | Declares color-scheme and injects darkreader-lock during the pre-Vue inline theme bootstrapping in dark mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<meta name="color-scheme" content="light dark">to declare native dark mode support (web standard)<meta name="darkreader-lock">when dark mode is active, so Dark Reader and similar extensions don't apply their own dark theme on top of oursTest plan
🤖 Generated with Claude Code